search

kudago / smart-app-banner

Lightweight smart app banner with no jquery requirement
MIT License
528 stars 251 forks source link

add cookie AppId specific #100

Closed alexeylindin closed 6 years ago

alexeylindin commented 6 years ago

Current implementation doesn't support rendering multiple banners across pages. E.g. Home page has smart-banner for app1, and 3rd level page got app2. If we close smart-banner for app1, we won't render smart-banner app2.

alexeylindin commented 6 years ago

Nice question! From my point of view from business perspective it would be nice to remind once more about application. This is the first option. Person will click/close banner and everything will work the same way as right now.

If this is not suitable option I could make additional check for old cookie. However it's not clear in case of multiple application. How could we determine that existing cookie refers to appId1 or appId2? So as the second option I would propose to remove old one if it is found, show banner and place new one.