search

kudago / smart-app-banner

Lightweight smart app banner with no jquery requirement
MIT License
526 stars 250 forks source link

When use this tool in universal web app , it will throw error on desktop browser! #102

Closed liwonder closed 6 years ago

liwonder commented 6 years ago

https://github.com/kudago/smart-app-banner/blob/ca24c7c4150e43d83f89fe601c119f4cf4bd90ed/index.js#L83

I think this line caused this error, when view the web app in desktop browser, the type will be undefined.

@dy FYI

alexeylindin commented 6 years ago

@liwonder could you please check your version number. This should work in 1.5.1

liwonder commented 6 years ago

Thanks @AlexeyLyndin, saw the changes there, and I was complain about the version 1.5.0. I have placed the constructor into a "try...catch" to prevent the error from showing in console! : )

alexeylindin commented 6 years ago

@liwonder looks like i could close this issue, isn't it?

liwonder commented 6 years ago

Yes, thanks! @AlexeyLyndin