search

kudago / smart-app-banner

Lightweight smart app banner with no jquery requirement
MIT License
526 stars 250 forks source link

Double banner on iOS fix #80

Closed tomek-f closed 7 years ago

tomek-f commented 7 years ago

Fix for os.vesion like '9.3.2' that returns NaN

DaSchTour commented 7 years ago

The same as #75

DaSchTour commented 7 years ago

The problem is also handled in #68

Chrysweel commented 7 years ago

+1 In my ipad, I see double navbar!

theonicolaou commented 7 years ago

I can also see the native banner and plugin banner (in iOS 10.2, iPhone SE). Is there an ETA for a fix for this?

danhodkinson commented 7 years ago

the fix is relatively straightforward. the issue is with this part: Number(agent.os.version) >= 6

it seems to have an issue with the 10.3.2 term. Instead you can just use parseFloat(agent.os.version) or parseInt(agent.os.version) which will give you an actual number to test against.

So hopefully this gets PR'd soon. But for anybody looking for a fix.. it's simple to update yourself

mauritsvanrees commented 7 years ago

I can confirm that this helps. I would say this is slightly better than the fix in #75 because that one does not explicitly use a radix of 10 for parseInt, and a radix is recommended. But there may be other opinions and it may not matter in this case because apple probably does not report a zero in front of its version numbers.

Ericky14 commented 7 years ago

Hello,

Is this branch getting merged to master anytime soon?

lucaboieru commented 7 years ago

Hello!

Any progress with this pull request? Can someone merge it if everything is okay? I think the demand for this fix is quite high.