search

kudago / smart-app-banner

Lightweight smart app banner with no jquery requirement
MIT License
526 stars 250 forks source link

Add option to disable native iOS banner but keep separate styling on different platforms #84

Open theonicolaou opened 7 years ago

theonicolaou commented 7 years ago

Hi,

Is there an option (or can it be implemented) so that the native iOS banner can be disabled and keep the different styling on the banners on each platform? I'm aware there is a "force" and "theme" option but this forces iOS or Android styles on both whereas I want the plugin banner to display with iOS styles on iOS and Android styles on Android.

The reason why I am asking is partly to get around the issue with the native iOS banner displaying in addition to the plugin banner. Assuming this issue got resolved, one might prefer to display the native banner on iOS however the plugin banner allows flexibility in defining the content of the banner whereas the native one does not.

Hope to hear your thoughts on this soon!

Thanks

theonicolaou commented 7 years ago

Just to add - I think what I am looking for is in this PR which was submitted in November 2016: https://github.com/kudago/smart-app-banner/pull/66. Is there any update on if/when this PR will get merged into Master?

Thanks

Theo

allexgut commented 7 years ago

@theonicolaou I've fixed the double banner issue by renaming the meta tag that's used for the Apple App Store. This way the native iOS banner doesn't get triggered at all, but the custom javascript one (this one) does. Want me to create a PR for that?

loferreiranuno commented 6 years ago

I could we override those tags?