search

kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)
https://kudo.dev
Apache License 2.0
1.18k stars 103 forks source link

update for goreleaser based on deprecation #1606

Closed kensipe closed 4 years ago

kensipe commented 4 years ago

https://goreleaser.com/deprecations/#brewsgithub

to test: goreleaser check

Signed-off-by: Ken Sipe kensipe@gmail.com

alenkacz commented 4 years ago

should we note somewhere which version of goreleaser we currently support? Is there a way to somehow "fix" it like if we would be using go.mod or other dependency resolution thing?

kensipe commented 4 years ago

that's a great point @alenkacz . My initial reaction was resistant because it is generally the latest release of goreleaser and it seems like a burden to update docs for every change... however I have a strong preference to have a repeatable, reproducible and traceable build chain. Unfortunately goreleaser, while a go application, is a binary and isn't managed in the build chain via tools.go etc. It seems that if we had the release as part of a CI build (which we should drive to) that the version will be either on the build image or be part of the build infrastructure pipeline scripts.

I don't see it as blocking this PR. I'll write an issue regarding this which can prioritize.

Thanks for thinking big picture and driving dev / release maturity in the process!