kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)
https://kudo.dev
Apache License 2.0
1.18k stars 103 forks source link

Don't warn if parameter is only used as trigger #1618

Closed nfnt closed 4 years ago

nfnt commented 4 years ago

What this PR does / why we need it: Parameters can be used to only trigger plans without being used in any templates. In this case no warning should be printed when verifying a package.

Fixes #1617

kensipe commented 4 years ago

My leaning has changed :), The more I think about it... there should be a verifier for triggers / plan names (which is performed irrespective of use). This should be captured as an error and would cover this situation. I'm not sure if that needs to be duplicated here. This seems 👌 the way it is but we need additional logic which I will capture in an issue.