kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)
https://kudo.dev
Apache License 2.0
1.18k stars 103 forks source link

Wait until the manager is actually gone before continuing the upgrade #1635

Closed ANeumann82 closed 4 years ago

ANeumann82 commented 4 years ago

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

Fixes #1633 #1632

ANeumann82 commented 4 years ago

agree with @alenkacz Also... I much prefer to move k8s specific functionality to that package. What we are deleting or waiting for should be declared here (manager) but the logic of how to delete or wait should be encapsulated in a kube / kubernetes package. Not a blocker as there is a prior art... but a kind loving nug :)

Good point. I've started out that way, but that was a bit too generic: In the kubernetes package I'd like to have a generic version of this, which would need the dynamic.Interface client which we currently don't have in the kubectl client.

I'm not opposed to adding it there though. Especially as we have to wait for the webhook resource as well, I think it makes sense to generalise this.