Fix imports that were missed

kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)

https://kudo.dev

Apache License 2.0

1.18k stars 103 forks source link

Fix imports that were missed #1679

Closed ANeumann82 closed 4 years ago

ANeumann82 commented 4 years ago

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

ANeumann82 commented 4 years ago

Merged without 24h wait because it fixes a broken main.

kensipe commented 4 years ago

@ANeumann82 how did PR testing not catch this? do we need to fix something?

ANeumann82 commented 4 years ago

@kensipe Well, the issue here is that GitHub allows a PR to be merged even if it doesn't contain the latest changes from main - unless there are conflicts. (This is good in my mind, otherwise it would become pretty cumbersome to merge multiple PRs).

In this case "main" contained some new code that was not covered by this PR, that's why this PRs testing didn't catch it. It would have been correct to merge main into the other PR before merging it into main.