search

kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)
https://kudo.dev
Apache License 2.0
1.17k stars 103 forks source link

Support both v1 and v1beta1 crds #1723

Closed alenkacz closed 3 years ago

alenkacz commented 3 years ago

What would you like to be added: v1 crds are around since 1.16, to be ready when v1beta1 is dropped, we should add v1 support

Why is this needed:

alenkacz commented 3 years ago

so I started looking into this, I think it's possible to have both versions in with some amount of work that's like ... 1 day of work tops I think.

But I started actually thinking about whether we need it. v1 is from 1.16. EKS have 1.17, Konvoy will be 1.16 in 1.6. Do we still feel like we need to support 1.16? Based on the information I know I would be for dropping v1beta1 and just migrating to v1 in the next version of KUDO.

ANeumann82 commented 3 years ago

I'm totally ok with just replacing v1beta1 with v1. I'm not sure if we should target that for KUDO 0.18 or KUDO 0.19, but I don't think it's worth supporting both, unless someone has a very good use case.

kensipe commented 3 years ago

removing the deprecated v1beta1 has been pushed out 2 versions... there is a lot of room between 1.16 and 1.22. I am a fan of moving to v1 only (and trying to time it right).

nfnt commented 3 years ago

The decision to keep using v1beta1 CRDs in KUDO 0.17 wasn't motivated by Kubernetes support, but by other tools not supporting v1 CRDs yet. Mainly cert-manager which is used in older versions in some environments. If we can require versions of cert-manager supporting v1 CRDs, we should be fine with using v1 CRDs only.

alenkacz commented 3 years ago

@nfnt oh I meant v1 only for our crds, I don't think we need to wait for cert-manager, do we?

@kensipe as for the timing, I was thinking about next release

alenkacz commented 3 years ago

based on talks with @nfnt the concern was around the need to support so old cert manager that it could not even handle crd v1 in runtime, but that should not be the case anymore. So ... any other concerns going v1 in the next release? @kensipe @nfnt @ANeumann82 @zen-dog

kensipe commented 3 years ago

sounds good! seems like a good idea / timing!