search

kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)
https://kudo.dev
Apache License 2.0
1.17k stars 103 forks source link

Integration test command should run all integration tests #1738

Closed alenkacz closed 3 years ago

alenkacz commented 3 years ago

We agreed on this with Andreas here https://kubernetes.slack.com/archives/CG3HTFCMV/p1603361976115700?thread_ts=1603360951.111500&cid=CG3HTFCMV

Context: There was a PR that has splitted KUTTL tests out of integration-test command. The reason was to be easily able to run just a single test. But as a result, command that's named integration-test now runs only a subset of integration tests and I think that's very confusing. The solution is to keep kuttl test separate for whoever needs it but have all integration tests again under one makefile command.

kensipe commented 3 years ago

I prefer to think of "integration" as Go integration tests... and kuttl as mainly e2e tests. this blurs that.

alenkacz commented 3 years ago

@kensipe yeah I see how that can be confusing but these tests are really integration tests (and yes, we have kuttl e2e tests as well)

I would actually say that for kuttl integration and e2e are on the same level, it just depends whether you use startControlPlane flag or not (if yes, you're doing integration not e2e in the sense it's commonly defined)