"package add plan" for "deploy" reports ">> plan name must be unique" and contradicts documentation

[javajon]

What happened:

Getting unexpected error:

$ kubectl kudo package add plan
✗ Plan Name: deploy
>> plan name must be unique

What you expected to happen:

No error as documented like this:

$ kubectl kudo package add plan
✔ Plan Name: deploy
✔ serial
Phase 1 name: main
✔ parallel
Step 1 name: everything
✔ app
✗ Add another Task:
✗ Add another Step:
✗ Add another Phase:

How to reproduce it (as minimally and precisely as possible):

Two options:

1) Following the KUDO doc instructions here. 2) Follow Katacoda scenario here and change version on step 2 from VERSION=0.15.0 to latest VERSION=0.17.2 then experience the problem in step 3 under Add a Plan.

The change happened sometime after 0.15.0.

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):

  Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean",BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
  Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean",BuildDate:"2020-03-25T14:50:46Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

• Kudo version (use kubectl kudo version):

  $ kubectl kudo version

  KUDO Version: version.Info{GitVersion:"0.17.2", GitCommit:"d902714c", BuildDate:"2020-11-16T20:34:11Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64", KubernetesClientVersion:"v0.19.2"}

• Operator:
• operatorVersion:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others: Use katacoda scenario as mentioned above and all info is there.

[alenkacz]

@javajon thanks for submitting this! I think this is actually docs issue because currently the deploy plan gets created by default. This is what get scaffolded:

plans:
  deploy:
    phases:
    - name: deploy
      steps:
      - name: deploy
        tasks:
        - deploy
      strategy: serial
    strategy: serial

so either we need to not do that or change the documentation.

@javajon any preferences as to what would be better for you from user perspective?