kudobuilder / kudo

Kubernetes Universal Declarative Operator (KUDO)
https://kudo.dev
Apache License 2.0
1.17k stars 103 forks source link

Cannot upgrade Cassandra from 3.11.6 to 3.11.7 #1758

Closed farhan5900 closed 3 years ago

farhan5900 commented 3 years ago

What happened: While upgrading Cassandra from 3.11.6 to 3.11.7, the upgrade failed with the following error message, despite being parameter passed for NUM_TOKENS:

Error: failed to update instance for new operatorversion default/cassandra-3.11.7-1.0.3: admission webhook "instance-admission.kudo.dev" denied the request: failed to check immutable parameters for Instance default/cassandra-instance: parameter 'NUM_TOKENS' was changed to immutable in operator version cassandra-3.11.7-1.0.3 but no value was provided

What you expected to happen: Successful upgrade from Cassandra 3.11.6 to 3.11.7

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?: No

Environment:

ANeumann82 commented 3 years ago

@farhan5900 Can you recheck the scenario? I just tested this locally and it worked as expected:

aneumanns-MBP:kudo-cassandra-operator aneumann$ kubectl-kudo upgrade cassandra --instance cassandra-instance --app-version 3.11.7
operatorversion default/cassandra-3.11.7-1.0.2 created
Error: failed to update instance for new operatorversion default/cassandra-3.11.7-1.0.2: admission webhook "instance-admission.kudo.dev" denied the request: failed to check immutable parameters for Instance default/cassandra-instance: parameter 'NUM_TOKENS' was changed to immutable in operator version cassandra-3.11.7-1.0.2 but no value was provided
aneumanns-MBP:kudo-cassandra-operator aneumann$ kubectl-kudo upgrade cassandra --instance cassandra-instance --app-version 3.11.7 -p NUM_TOKENS=256
operatorversion default/cassandra-3.11.7-1.0.2 already installed
instance default/cassandra-instance updated
aneumanns-MBP:kudo-cassandra-operator aneumann$ 
farhan5900 commented 3 years ago

Thanks, @ANeumann82 for checking. I also checked again, It is working fine now.