kudobuilder / kuttl

KUbernetes Test TooL (kuttl)
https://kuttl.dev
Apache License 2.0
677 stars 86 forks source link

[Bug]: Build fails with Go 1.23 because of changed testing.testDeps #546

Closed stefanb closed 2 months ago

stefanb commented 2 months ago

What happened:

build fails with

# github.com/kudobuilder/kuttl/pkg/test/utils
  pkg/test/utils/testing.go:44:28: cannot use &testDeps{} (value of type *testDeps) as "testing".testDeps value in argument to testing.MainStart: *testDeps does not implement "testing".testDeps (missing method InitRuntimeCoverage)

What you expected to happen:

build to succeed.

How to reproduce it (as minimally and precisely as possible): 1) Install Go 1.23 (rc1, rc2 or later) 2) build

Anything else we need to know?:

Related:

Environment:

porridge commented 2 months ago

Thanks for the report @stefanb ! Looks like we'll need something similar to https://github.com/hofstadter-io/hof/pull/392/files#diff-f08861a287bce287f8852024b94cd158021f70f1b18fdd846aabbde6d3bfc607R69 including making the testing.MainStart call versioned with build tags 🤔

porridge commented 2 months ago

@stefanb can you please check if https://github.com/kudobuilder/kuttl/pull/548 works for you?