search

kudos / combine.fm

🔊 Make sharing from music services better.
https://combine.fm
108 stars 8 forks source link

Match failing for some albums between spotify and google music #20

Open renatolond opened 7 years ago

renatolond commented 7 years ago

I've had this issue with two albums I've tried, and they don't seem to have anything in common. The album exists in both services, but match.audio seems to not be able to match them.

The first was the get down soundtrack: https://match.audio/spotify/album/0UqBp39R5ARECBnxnVk25l https://match.audio/google/album/Bzudnfixxsk647fqpbftbclgety

The second is from a Brazilian duo: https://match.audio/spotify/album/4P09BJFkwTM9QW89RvyQy5 https://match.audio/google/album/Bfybhxorsk3m3g7xooyihpwghri

But looking at other albums currently at the recently shared, it seems they share the same issue.

kudos commented 7 years ago

Thanks for the report. It looks like Google messed with the API, but it should be resolved now. I'll take a look at filling in the missing data it produced.

kudos commented 7 years ago

Ok, it looks like I introduced a lot of bugs around track matching when I switched data stores. I've pushed some fixes and matching improvements today. I more than welcome any improvements with accompanying tests :)

Your second set of links are interesting. At first I thought that it was the diacritic causing problems, but it's that exact album that inexplicably doesn't work, test it here: https://developer.spotify.com/web-api/console/get-search-item/?q=album:Fica%20artist:Anavit%C3%B3ria&type=album. Seems like a bug in Spotify's API to me.

kudos commented 7 years ago

iTunes has a similar problem with Fica as Spotify. If I have some way of knowing I can get iTunes to check the Brazilian store it can find it: https://itunes.apple.com/search?term=Anavit%C3%B3ria%20%20Fica&media=music&entity=musicTrack versus https://itunes.apple.com/br/search?term=Anavit%C3%B3ria%20%20Fica&media=music&entity=musicTrack

Spotify should return content from all regions unless you tell it otherwise though.

kudos commented 7 years ago

OK, I'm wrong. Spotify return what markets content is available in alongside the content, but will search the US market by default.

@renatolond I'll spend a little more time investigating, but If you've any ideas on solving this let me know.

kudos commented 7 years ago

Spotify issue here: https://github.com/spotify/web-api/issues/194

In the meantime I'm now iterating over several markets when looking for matches.

renatolond commented 7 years ago

I always forget about the region differences, thanks a lot for the investigation :) I'll take a look on your changes and see if I can help with tests and improvements ;)