Add ytmusic service - Githubissues

kudos / combine.fm

🔊 Make sharing from music services better.

https://combine.fm

107 stars 8 forks source link

Add ytmusic service #315

Closed renatolond closed 3 years ago

renatolond commented 3 years ago

Tasks:

[x] Parse urls from tracks
[x] Parse urls from albums (with browse style)
[x] Parse urls from albums (with playlist style)
[x] search for track
[x] search for album
[x] Add ytmusic to db enums
[ ] Some kind of db migration?
[x] Improve search for album by checking results title and other info
[x] Add ytmusic logo to the UI

Fixes #177

renatolond commented 3 years ago

I didn't quite understand how I can add new values to the enums using sequelize. I had to cheat a bit to get my local environment running, because it was complaining the models didn't exist, so I'm guessing there's steps I was missing and that are not in the README. I'm imagining a migration is needed?

renatolond commented 3 years ago

Images returned by ytmusic seem to always have some kind of border, not sure how to treat that, looks weird in the ui :T https://i.ytimg.com/vi/8VR-ATv5bTc/maxresdefault.jpg

kudos commented 3 years ago

Really awesome work here, man, thank you! I don't think I'll get a chance to review today, I need to spin up a dev env to play around with the branch first. Should get a look early in the week though :)