search

kuestess / homebridge-platform-insteonlocal

Homebridge platform plugin for local Insteon control
Other
76 stars 26 forks source link

Target Keypad LED Function Broken? #300

Closed THX723 closed 9 months ago

THX723 commented 10 months ago

Target Keypad LED is acting wonky with the latest v0.5.10 release.

My configuration has 2 or more targeted keypads defined. Only the 1st Keypad LED is being triggered, not the subsequent ones. Curiously the log is correctly showing all targeted keypads being triggered however.

When I rolled back to v0.5.8, everything is working as it should. I did not test v.0.5.9 btw.

kuestess commented 10 months ago

@THX723 I did have to touch some of that code in the latest update which might have introduced some unintended side effects. The new i3 keypad is 4 buttons to go along with the existing 6 and 8 button configurations, so had to add some logic to look at the number of buttons specified in the config and choose a button map based upon that. Let me take a look and see if I can figure out what's going on.

THX723 commented 10 months ago

@kuestess Yup, I figured as much. Thanks.

kuestess commented 9 months ago

@THX723 It was a stupid copy/paste error. 0.5.11 should fix it.

THX723 commented 9 months ago

@THX723 It was a stupid copy/paste error. 0.5.11 should fix it.

Ha! Thanks for the fix.

THX723 commented 9 months ago

Quick validation test passed with flying color. Thanks again @kuestess.