search

kuestess / homebridge-platform-insteonlocal

Homebridge platform plugin for local Insteon control
Other
76 stars 26 forks source link

InsteonUI/Devices 'Add to config' creates broken config entry #308

Open loukrieg opened 5 months ago

loukrieg commented 5 months ago

In the screenshot below, I have a device discovered via 'Get Devices'.

InsteonUI

After clicking 'Add to config', the log shows the plugin attempting to add the device, but with deviceType: undefined

InsteonLocal Log

The result in the Homebridge JSON Config is an incomplete entry:

Config

If I examine the entry in the Plugin Config editor, you can see that the value for Dimmable is true rather than yes.

Plugin Config

Correcting the value to yes in the Plugin Config editor and saving + restarting Homebridge, results in a correct Homebridge config entry.

kuestess commented 5 months ago

@loukrieg Thanks for the very thorough issue report - really helpful! For the device above, does your insteon.json file (should be in your homebridge directory) have device subcategory info?

loukrieg commented 5 months ago

@kuestess Yes, it does:

` { "name": "Office Track Lights", "deviceID": "482D44", "info": { "id": "482D44", "firmware": "45", "deviceCategory": { "id": 1, "name": "Dimmable Lighting Control" }, "deviceSubcategory": { "id": 32 }, "isDimmable": true, "isLighting": true, "isThermostat": false }, "operatingFlags": { "D1": "01", "D2": "01", "D3": "00", "D4": "00", "D5": "20", "D6": "20", "D7": "1B", "D8": "80", "D9": "1F", "D10": "00", "D11": "01", "D12": "00", "D13": "00", "D14": "00", "programLock": "off", "ledEnable": "off", "resumeDim": "off" }, "databaseDelta": "00", "links": [ { "flags": "AA", "controller": false, "isInUse": true, "hasBeenUsed": true, "isLast": false, "group": 0, "id": "454DF3", "data": [ "32", "1C", "01" ], "onLevel": 20, "at": 4095 }, { "flags": "E2", "controller": true, "isInUse": true, "hasBeenUsed": true, "isLast": false, "group": 1, "id": "454DF3", "data": [ "03", "1C", "01" ], "onLevel": 2, "rampRate": 360000, "at": 4087 } ] },

`