search

kuhn-ruess / Checkmk-Checks

Checks and Stuff for Check_MK
MIT License
39 stars 21 forks source link

No default value for max_age #15

Closed robertoschwald closed 4 years ago

robertoschwald commented 4 years ago

If no parameters rule is defined for the bacula services, you get this error in the sensors state entries:

Invalid check parameter: Age of last Backup: The datatype must be a tuple, but is bool Variable: checkgroup_parameters:bacula_jobs Parameters: {'crit_states': ['E', 'f'], 'max_age': False, 'ok_states': ['T', 'R']}

Reson I think is: There is no default_value defined in the wato bacula.py file.

I first thought it was something introduced by me in #14, but I'm convinced it was always like this. Will provide a new PR to fix this.

robertoschwald commented 4 years ago

As you see in #16, max_age was defined as bool in the factory_settings, which is wrong, as it is Tuple(warn,critical).

robertoschwald commented 4 years ago

Maybe it's a good idea to upload the new version to CheckMK Exchange as soon as you merged #16