kuhn-ruess / Checkmk-Checks

Checks and Stuff for Check_MK
MIT License
36 stars 20 forks source link

Bacula_jobs miss State "Warning" #30

Closed Jounixjo closed 2 years ago

Jounixjo commented 2 years ago

State Warning is not covered by bacula.py plugin and bacula_jobs. Therefore this State results always in a Warning and can not be configured within CMK GUI. Adding following line will solve it. Tested in Check MK 2.0.0p9 and 1.6.0p17.

('W',  "Terminated with warnings"),

bacula_job_states = [ ('A', "Canceled by user"), ('B', "Blocked"), ('C', "Created, but not running"), ('c', "Waiting for client resource"), ('D', "Verify differences"), ('d', "Waiting for maximum jobs"), ('E', "Terminated in error"), ('e', "Non-fatal error"), ('f', "fatal error"), ('F', "Waiting on File Daemon"), ('j', "Waiting for job resource"), ('M', "Waiting for mount"), ('m', "Waiting for new media"), ('p', "Waiting for higher priority jobs to finish"), ('R', "Running"), ('S', "Scan"), ('s', "Waiting for storage resource"), ('T', "Terminated normally"), ('t', "Waiting for start time"), ]

Bastian-Kuhn commented 2 years ago

Hi, thank you very much for this Update.

Would it be OK for you, to update the last digit on the version (info file in src), and use the packer command to create also an updated MKP file? Then the Pull Request would be complete, and I would not need to intervene?

regards, Bastian

Jounixjo commented 2 years ago

Hi,

I were able to create the MKP file and upload it in another Pull request. I am sorry, I am not that familiar with GIT and pull requests in such detail yet, therefore there exist three pull requests now.

Thanks four your work with Check MK.

Mit freundlichen Grüßen / Kind regards

Johannes Wendel


From: Bastian Kuhn @.> Sent: Monday, August 23, 2021 12:04 To: Bastian-Kuhn/Check_MK-Treasures @.> Cc: Jounixjo @.>; Author @.> Subject: Re: [Bastian-Kuhn/Check_MK-Treasures] Bacula_jobs miss State "Warning" (#30)

Hi, thank you very much for this Update.

Would it be OK for you, to update the last digit on the version (info file in src), and use the packer command to create also an updated MKP file? Then the Pull Request would be complete, and I would not need to intervene?

regards, Bastian

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBastian-Kuhn%2FCheck_MK-Treasures%2Fissues%2F30%23issuecomment-903624812&data=04%7C01%7C%7C2b5063220b84436523b208d9661d6984%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637653098767732384%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=eXDBcJT5F6QnAtmvI6UpXGSwpBkDge7izkI%2B0JWJdLM%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASU4IA3T2QM5R64I4XRIIOLT6IMLHANCNFSM5CUFENKQ&data=04%7C01%7C%7C2b5063220b84436523b208d9661d6984%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637653098767742332%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qPedR0udk%2BsHPdccxzO0Lx9Eaz61M4NK6OrNPDiDnZc%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C2b5063220b84436523b208d9661d6984%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637653098767742332%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FEFKX4jC5mVBhqbxNY1%2BnbnBp7W3a2IJ7hb%2B%2FvFwPLc%3D&reserved=0 or Androidhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04%7C01%7C%7C2b5063220b84436523b208d9661d6984%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637653098767752287%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mEPU05uRbVZg3Sfv6o5lhHnFR25hVV%2BjyIleOKqJBBg%3D&reserved=0.

Bastian-Kuhn commented 2 years ago

Thank you very much. Don't worry, I merged them all.