kuhn-ruess / Checkmk-Checks

Checks and Stuff for Check_MK
MIT License
40 stars 22 forks source link

Possible to add volume information to pure? #41

Closed mfaust78 closed 1 year ago

mfaust78 commented 2 years ago

Pure check for CheckMK is cool, but lacks Volume / Array usage data. Would it be possible to add that? Based on the Pure Storage FlashArray REST Client it seams possible to get array space data (GET https://array.example.com/api/1.19/array?space=true) as well as volume space data (GET https://array.example.com/api/1.19/volume?space=true). Now sure if the Python library allow/manages that.

Bastian-Kuhn commented 2 years ago

Hello, I guess it would. But I develop these plugins only during consulting. Main Reasons is that I have none of these devices myself, while when on Consumer site I just can access them.

carkle1971 commented 1 year ago

Added volumes, replace agent_pure with the changed one. You will see volumes and used space and so on. It show in TB in PB now but that is works in progress. So is the performance stats. I am working on that.
https://github.com/carkle1971/Scripts/tree/main/CheckMK/PureStorage

c3rberus commented 1 year ago

Any plans to merge carkle1971 changes to agent_pure and get a new mkp?

Bastian-Kuhn commented 1 year ago

Got no Pull request yet

Bastian-Kuhn commented 1 year ago

done, thanks again :)