Closed carkle1971 closed 1 year ago
Bastian-Kuhn
commented
1 year ago Hi,
Thanks for the Pull request. Sadly it's seams your Editor reformated the whole code. We use just 4 Spaces for intents. Can you please fix that, the file changes normaly should only show what you have changed and not the whole file :)
carkle1971
commented
1 year ago I work with Visual Studio Code. I downloaded the files and changed them then. I will have a look tomorrow
Met vriendelijke groet, Kind Regards, Bien à vous, Med vennlig hilsen, Mit freundlichen Grüßen, Carlo Kleinloog
From: Bastian Kuhn @.> Sent: Wednesday, January 25, 2023 7:13 PM To: Bastian-Kuhn/Check_MK-Treasures @.> Cc: Kleinloog, Carlo (Bilfinger Shared Services B.V.) @.>; Author @.> Subject: [EXTERNAL] Re: [Bastian-Kuhn/Check_MK-Treasures] Pull request for new MKP (PR #44)
This e-mail is from an external source - be cautious, particularly with links, attachments and unusual requests.
Hi,
Thanks for the Pull request. Sadly it's seams your Editor reformated the whole code. We use just 4 Spaces for intents. Can you please fix that, the file changes normaly should only show what you have changed and not the whole file :)
— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Bastian-2DKuhn_Check-5FMK-2DTreasures_pull_44-23issuecomment-2D1404031501&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=te3CV4KJVrhFDmXnuKcs-FQ5b6pVh28Q_By5YqcxDW0VHl8PXQIIln4ZtP3CID9k&s=hjwMhW9tnFqkkuA4qNrni45TpCaHxSLuBVtuuDe8dqM&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUSYL6I7J45LVIAQ37AFARLWUFUJJANCNFSM6AAAAAAUFFEILY&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=te3CV4KJVrhFDmXnuKcs-FQ5b6pVh28Q_By5YqcxDW0VHl8PXQIIln4ZtP3CID9k&s=FF4_Mih4SZ6wX_fyJz7RKu3cCHqBNkQifCcvWvllD04&e=. You are receiving this because you authored the thread.Message ID: @.**@.>>
Bastian-Kuhn
commented
1 year ago Perfect, thank you.
If you work with such a suite, there should be a Python Extension. And there you can 100% activate pylint, which will solve almost every formatting Problem I complained in the review :)
carkle1971
commented
1 year ago Bastian,
I updated just now. Can you please check if it is okay now?
Met vriendelijke groet, Kind Regards, Bien à vous, Med vennlig hilsen, Mit freundlichen Grüßen, Carlo Kleinloog
From: Bastian Kuhn @.> Sent: Wednesday, January 25, 2023 7:21 PM To: Bastian-Kuhn/Check_MK-Treasures @.> Cc: Kleinloog, Carlo (Bilfinger Shared Services B.V.) @.>; Author @.> Subject: [EXTERNAL] Re: [Bastian-Kuhn/Check_MK-Treasures] Pull request for new MKP (PR #44)
This e-mail is from an external source - be cautious, particularly with links, attachments and unusual requests.
Perfect, thank you.
If you work with such a suite, there should be a Python Extension. And there you can 100% activate pylint, which will solve almost every formatting Problem I complained in the review :)
— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Bastian-2DKuhn_Check-5FMK-2DTreasures_pull_44-23issuecomment-2D1404040818&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=zfTKvwDM9qeVMTZdRZkqjoJ_rw7z95poT4Uv6vBmsWOdO1fuVn-WxmYWUQ-DWEDd&s=Ly_297_jeBWHJ1quiCIcSQYt6c_ST7uIbYN08x6-k0I&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUSYL6LMWE4QFKZAVVS2AZDWUFVJPANCNFSM6AAAAAAUFFEILY&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=zfTKvwDM9qeVMTZdRZkqjoJ_rw7z95poT4Uv6vBmsWOdO1fuVn-WxmYWUQ-DWEDd&s=awC32vQkJ-jKRn4OPe8EkJpTCedk39EJSeTFJE0vM0g&e=. You are receiving this because you authored the thread.Message ID: @.**@.>>
Bastian-Kuhn
commented
1 year ago Hi,
you haven't updated the Pull Request yet. It's still with the old commits.
Best Bastian
carkle1971
commented
1 year ago I am updating soon.
Met vriendelijke groet, Kind Regards, Bien à vous, Med vennlig hilsen, Mit freundlichen Grüßen, Carlo Kleinloog
From: Bastian Kuhn @.> Sent: Tuesday, January 31, 2023 8:11 AM To: Bastian-Kuhn/Check_MK-Treasures @.> Cc: Kleinloog, Carlo (Bilfinger Shared Services B.V.) @.>; Author @.> Subject: [EXTERNAL] Re: [Bastian-Kuhn/Check_MK-Treasures] Pull request for new MKP (PR #44)
This e-mail is from an external source - be cautious, particularly with links, attachments and unusual requests.
Hi,
you haven't updated the Pull Request yet. It's still with the old commits.
Best Bastian
— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Bastian-2DKuhn_Check-5FMK-2DTreasures_pull_44-23issuecomment-2D1409872972&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=dKvNehGRQLTCKaxHyT6rDtQtjzN1i2i5-OSKMMrBE6aDUjIHkuzk5-fTuZN3ku0J&s=-HPDWaJy8qwqYHn4isftIiuAbos7imXGryXXctnYpJE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUSYL6PXWAJG7263OKJ2UG3WVC3ITANCNFSM6AAAAAAUFFEILY&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=dKvNehGRQLTCKaxHyT6rDtQtjzN1i2i5-OSKMMrBE6aDUjIHkuzk5-fTuZN3ku0J&s=yCuISj2pDEXaqHTFNDXDYdRe5V-5VwBaXKCJ5-km-qs&e=. You are receiving this because you authored the thread.Message ID: @.**@.>>
carkle1971
commented
1 year ago Creating new request with new files
carkle1971
commented
1 year ago Hi Bastian,
Sorry for that. I am new to Github as a contributor. I forked your Check_MK-Treasures, changed and added the files in the pure directory. Created new pull request. I hope this is the correct way. I followed a YouTube video ☺ I am still working on creating one file for the volumes that contains volume data, performance data and details, so we can have one service per volume in Check_MK. It’s good for me to learn Python and Check_MK a bit more.
Met vriendelijke groet, Kind Regards, Bien à vous, Med vennlig hilsen, Mit freundlichen Grüßen, Carlo Kleinloog
From: Bastian Kuhn @.> Sent: Tuesday, January 31, 2023 8:11 AM To: Bastian-Kuhn/Check_MK-Treasures @.> Cc: Kleinloog, Carlo (Bilfinger Shared Services B.V.) @.>; Author @.> Subject: [EXTERNAL] Re: [Bastian-Kuhn/Check_MK-Treasures] Pull request for new MKP (PR #44)
This e-mail is from an external source - be cautious, particularly with links, attachments and unusual requests.
Hi,
you haven't updated the Pull Request yet. It's still with the old commits.
Best Bastian
— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Bastian-2DKuhn_Check-5FMK-2DTreasures_pull_44-23issuecomment-2D1409872972&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=dKvNehGRQLTCKaxHyT6rDtQtjzN1i2i5-OSKMMrBE6aDUjIHkuzk5-fTuZN3ku0J&s=-HPDWaJy8qwqYHn4isftIiuAbos7imXGryXXctnYpJE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AUSYL6PXWAJG7263OKJ2UG3WVC3ITANCNFSM6AAAAAAUFFEILY&d=DwMCaQ&c=HIZawdDzIngf9EKVx3dimYy9B-kGp4mNBCT5TYgJGOg&r=OI3JArAupJom1QQBULWSwRLKH_GqWOhlBQcH8zN1Pe4&m=dKvNehGRQLTCKaxHyT6rDtQtjzN1i2i5-OSKMMrBE6aDUjIHkuzk5-fTuZN3ku0J&s=yCuISj2pDEXaqHTFNDXDYdRe5V-5VwBaXKCJ5-km-qs&e=. You are receiving this because you authored the thread.Message ID: @.**@.>>
Added array info like software version, software revision and Array ID. Added volume usage data, volume performance data and volume details like dedup and so on. The volume data is created in three separate services. I can not seem to get them in one service. I will keep trying for that.