kuhn-ruess / Checkmk-Checks

Checks and Stuff for Check_MK
MIT License
40 stars 22 forks source link

mysql_status: Update CheckMK 2.3 fails #76

Open TGion opened 5 months ago

TGion commented 5 months ago

We are trying to update CheckMK from 2.2.0p25.cre to 2.3. The update fails because of deprecated API calls:

01/06 Legacy check plugins...
Ignoring outdated plugin 'mysql.status': Format no longer supported -- this API is deprecated!

You can abort the update process (A) and try to fix the incompatibilities or continue the update (c).

Is this issue known? Are there any workarounds? Thanks in advance for your support!

Bastian-Kuhn commented 5 months ago

Hello,

There is no workaround, this plugin needs to be rewritten for the new Checkmk 2.3 API.

2.3 removed the 1.x APIs, deprecated the one introduced in 2.0 and introduced a whole new, but better supported Check API.

TGion commented 5 months ago

Hey Bastian,

thanks for your swift reply. Will you consider the rewrite to the new API in the near future (or ever)?

Bastian-Kuhn commented 5 months ago

Hi Tobias, as soon one of our consumers orders us. Can't tell you how soon that happens.

moschlar commented 2 months ago

Hi everyone - I took the liberty to migrate to the old new API in #80.

@Bastian-Kuhn Please let me know what you need in order to incorporate this from a licensing standpoint. I'm happy to grant all rights.

Bastian-Kuhn commented 2 months ago

@moschlar Thank you very much, will look into it. From the Standpoint of License, that is the one we use: https://github.com/kuhn-ruess/Checkmk-Checks?tab=MIT-1-ov-file#readme (MIT)

Tiippex commented 2 months ago

Hey, thanks for the update. I have tested the new version with CheckMK 2.3.0p13 Enterprise.

The perf o meter shows me an exception: Exception: 'PerfDataTuple' object is not subscriptable

image

Thanks for your work!

moschlar commented 2 months ago

@Tiippex Darn, sorry - I have just tested it with 2.2 since I have a bunch of other plugins preventing the upgrade... Will look into it!