kuhnertdm / wow-addon-updater

Python script for mass-updating World of Warcraft addons
GNU General Public License v3.0
116 stars 28 forks source link

Curse updated their site and this is not working any longer #14

Closed lithium720 closed 6 years ago

lithium720 commented 6 years ago

Title

adrien-martin commented 6 years ago

Hello, I'm facing the same problem.

I tried to fix it here: https://github.com/adrien-martin/wow-addon-updater, but not sure the patch is good enough for a pull request. At the moment it needs the beautifullsoup4 python3 package, it would be better without this dependency.

What was done:

Other notes:

lithium720 commented 6 years ago

I've cloned yours (@adrien-martin) and am using it now. It works. Nice work. It appears that @kuhnerdm has been MIA since early July.

rkik commented 6 years ago

Once I installed the beautifulsoup4 dependency, this worked great.

I was getting a the following warning, but otherwise things seemed to work :\Python35-32\lib\site-packages\urllib3\contrib\socks.py:37: DependencyWarning: SOCKS support in urllib3 requires the installation of optional dependencies: specifically, PySocks. For more information, see https://urllib3.readthedocs.io/en/latest/contrib.html#socks-proxies DependencyWarning

kuhnertdm commented 6 years ago

Thank you all very much for letting me know about this, and my apologies for not being able to fix this sooner. I've adapted @adrien-martin 's fix to eliminate the extra dependency, and pushed that change. Please let me know if you find any issues with the new version.