search

kuhnertdm / wow-addon-updater

Python script for mass-updating World of Warcraft addons
GNU General Public License v3.0
116 stars 28 forks source link

Fails to update Curseforge addons #24

Closed WhichMatt closed 6 years ago

WhichMatt commented 6 years ago

It seems that Curseforge has changed the way the add-ons are accessed. My current in.txt has add-ons linked as: https://www.curseforge.com/wow/addons/addon-name-here

Changing them to https://wow.curseforge.com/projects/addon-name-here seems to fix the issue

WhichMatt commented 6 years ago

In addition to this, certain add-ons appear to re-direct to https://www.wowace.com/projects/ instead, which I guess is messing up the getCurrentVersion calls.

Tessonic commented 6 years ago

I changed my curseforge url's in the in.text so that every www was a wow and every wow/addons was a projects but it didn't work. The updater opened and closed immediately as if my in.txt was empty.

kenany commented 6 years ago

Yup, seems like the old URLs are now 404s.

In addition, it does appear as though some CurseForge pages now redirect to WowAce. For example:

The addons affected by this get a version string of:

CTYPE html>\r\n<!--[if lt IE 7 ]> <html lang="en" class="no-js ie6
zurohki commented 6 years ago

Added some fixes to my datastoremods branch: https://github.com/zurohki/wow-addon-updater/branches

Give it a try, or the datastore+gui branch.

They should handle WowAce project pages now, and actually throw sensible errors for 404 pages instead of spewing garbage.

WhichMatt commented 6 years ago

I've cloned that branch and my first test run has gone perfectly. All add-ons in in.txt are using the form wow.curseforge.com/projects/, but some redirect to wowace.com. They all were able to update to latest versions with no problems.

Tessonic commented 6 years ago

It worked perfectly for me as well! My add-ons in in.txt are still using the form www.curseforge.com/wow/addons/[name] and all of them are up to date again.

kuhnertdm commented 6 years ago

Major apologies for my absence recently. I've just finished classes forever, so hopefully I'll be able to be much more responsive soon. This seems to be fixed by PR #20 , which has just been merged. Major thanks @zurohki