search

kuhnertdm / wow-addon-updater

Python script for mass-updating World of Warcraft addons
GNU General Public License v3.0
116 stars 28 forks source link

Checked for more edge cases, such as fail to find or fail to extract #26

Closed Delduwath closed 6 years ago

Delduwath commented 6 years ago

I'm not sure what curse has changed, but I was getting -1 returns on find that was putting very large 2,500 character versions including equal signs and line returns. These strange versions where messing up my installed.txt. So I added a check for when find returns -1, put a max character limit on versions of 300 characters, and replaced line returns and equal signs in versions with less harmful characters. I also had it changing my version even when the download failed, so I added a check to make sure it made it past the extraction before changing the version.

kuhnertdm commented 6 years ago

I believe this is fixed by the recent merge of #20 and further updates from @zurohki. Please let me know if this is not the case.