kuhnertdm / wow-addon-updater

Python script for mass-updating World of Warcraft addons
GNU General Public License v3.0
116 stars 28 forks source link

Addon Uninstaller #37

Closed khlam closed 6 years ago

khlam commented 6 years ago
grrttedwards commented 6 years ago

I'm leery of this feature, because it introduces behavior that someone may not expect from something called "WoW Addon Updater". In my opinion it should just update according to the configuration; it shouldn't go around deleting anything. Not to mention this is a breaking change.

khlam commented 6 years ago

@grrttedwards Yes, this is a radical new feature but I'd argue it's necessary to change the format of the installed versions file because there's currently nothing recording what's being downloaded and unzipped. A user could disable addons they don't want to use and comment out the URL, but then that's bloating up their directory. If a user did want to clean up the junk they're not using, then there's no clear reference to do it manually which can be especially tedious if you want to remove an addon like DBM.

As far as adopting this change, in my testing all I had to do was delete my old Installed Versions File, then run the script. Since it doesn't overwrite directories all my settings were saved, so if a user knows how to run the script I think it's a straightforward update.