ElvUI ExtraActionBars

Mayo77 commented 5 years ago

Not sure what happened since i changed nothing but now i just get errors when i try to update my addons. Curse looks like it changed maybe thats the issue i dunno

Please fix I love this addon!

Bigity commented 5 years ago

Same issue here

Bigity commented 5 years ago

Example: Installing/updating addon: elvui-oneextraactionbar to version: html>\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n \r\n ElvUI ExtraActionBars - Addons - World of Warcraft - CurseForge \r\n \r\n \r\n \r\n\r\n \r\n \r\n\r\n\r\n \r\n\r\n\r\n \r\n\r\n \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n \r\n\r\n\r\n\r\n\r\n \r\n\r\n <script src=\'https://www.google.com/recaptcha/api.js?onload=onloadCallback&render=explicit\' async defer>\r\n \r\n\r\n \r\n\r\n\r\n\r\n\r\n\r\n\r\n \r\n \r\n \r\n \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n \r\n \r\n \r\n

\r\n \r\n\r\n\r\n\r\n\r\n

\r\n

\r\n \r\n

\r\n

\r\n \r\n \r\n

\r\n

\r\n\r\n\r\n \r\n \r\n <a href="https://bit.ly/CurseForgeFeedback" target=\'_blank\' class="top-navnav-link no-underline " >\r\n Feedback\r\n \r\n <a href="https://authors.curseforge.com/forums" class="top-navnav-link no-underline hide" >\r\n Forums\r\n \r\n\r\n \r\n \r\n\r\n

\r\n

\r\n \r\n \r\n Login\r\n

Failed to download or extract zip file for addon. Skipping...

Latuchi commented 5 years ago

Same issue here. I believe this is happening because twitch/curse changed curseforge look of the site and they maybe did something in the backend too. I butchered the code and still can't seem to get downloads working.

Ghosthree3 commented 5 years ago

This will fix the problem, or it did for me. https://github.com/kuhnertdm/wow-addon-updater/pull/48

fadedtimes commented 5 years ago

made changes from #48 and confirmed it fixed the update issue I was having #47

Mayo77 commented 5 years ago

This is how i had my ini file originally so this #48 did not fix my problem, i will try to reinstall again.

Latuchi commented 5 years ago

Great job @Ghosthree3 #48 fixed the problem. :)

fadedtimes commented 5 years ago

This is how i had my ini file originally so this #48 did not fix my problem, i will try to reinstall again.

the 3 line changes for SiteHandler.py

https://github.com/kuhnertdm/wow-addon-updater/pull/48/commits/d28f20520d6aec2dc116e63236e38846c47b0fc2

Mayo77 commented 5 years ago

Ok well i downloaded it and now it works agian thank you guys so much you all rule! Problem solved!

Amazing how much you miss something like this when its gone! makes my life so much easier so thank you all you great people for helping !

sKGu8gxV commented 5 years ago

Hey, I tried the fix of replacing the curse url from https://wow.curseforge.com/projects/ to https://www.curseforge.com/wow/addons/ but that didn't work. Could someone please upload theirs somewhere, I'm thinking I misplaced a space or something somewhere and I haven't been able to find it. Thanks!

Mayo77 commented 5 years ago

To fix it; 1) Download the newest version of wowupdater on github as it has a fix in it, that was just added last night. 2) Not sure if needed but I also downloaded and installed the newest python (version 3.7.3) 3) only use this format in the in file https://www.curseforge.com/wow/addons/

that's all i did works great now.

MrUzagi commented 5 years ago

~~https://www.curseforge.com/wow/addons/ gives me a 404 when I use it manually,~~ ~~https://www.curseforge.com/wow/addons (no trailing slash) does not.~~

~~Could that be the problem?~~

Edit: But if I'd read better I'd probably have realized that it was meant as a prefix, in which case the first one should be correct. Please, feel free to ignore me. :-D

Mayo77 commented 5 years ago

https://www.curseforge.com/wow/addons/ first off, is not an addon so this specific example wouldn't work

this is an example of deadly boss mods : https://www.curseforge.com/wow/addons/deadly-boss-mods because that's the page in curseforge that has deadly boss mods .. you have to find this specific page for every single one of your addons.

You should review the proper install instruction on the main page and scroll down to "first time-setup" and start reading.

but when reading the install guide, it will mention other formats that "should work" but, only just use this type format as its verified working https://www.curseforge.com/wow/addons/deadly-boss-mods

It should work. If not you may need help from one of these other guys because maybe I'm missing something. I'm kinda a noob myself and these guys are much more experienced than myself. I'm Just trying to pay it forward.

sKGu8gxV commented 5 years ago

Thanks but it still doesn't work for me. I even reinstalled python twice (x64/x86) and tested on my linux rig (lubuntu). Here's the output https://pastebin.com/JDSL816s.

Testing it with only dbm https://www.curseforge.com/wow/addons/deadly-boss-mods

Ghosthree3 commented 5 years ago

Changing the URL isn't the fix, please read the actual commit in the pull request https://github.com/kuhnertdm/wow-addon-updater/pull/48 not just the comment. Reinstalling won't fix anything, the script is broken and has to be edited.

sKGu8gxV commented 5 years ago

Changing the URL isn't the fix, please read the actual commit in the pull request #48 not just the comment. Reinstalling won't fix anything, the script is broken and has to be edited.

Ah it works now. Sorry just created an account here for this issue and can't say I can code my way out of a shoebox. Thanks Ghost, for both the fix and informing me how to fix it!

SveSop commented 5 years ago

Yep. Confirmed to work again after adding https://github.com/kuhnertdm/wow-addon-updater/pull/48/commits/d28f20520d6aec2dc116e63236e38846c47b0fc2

dark0dave commented 5 years ago

I uh, am maintaining my own version: https://gitlab.com/dark0dave/wow-addon-updater. Help would very much be appreciated. @Ghosthree3 I took the liberty of merging in your prs.

torkus commented 5 years ago

There any many forks of this project but this one seems to be topmost in the network graph (for now): https://github.com/grrttedwards/wow-addon-updater

Having many choices is great but perhaps @dark0dave or @grrttedwards could toss a coin and pick a fork to collaborate on, as this project doesn't appear to have a maintainer anymore. It would benefit everybody who really loves wow-addon-updater.

But if you have no particular loyalty, and because I'm shameless in my plugs, you can find other CLI addon updaters in the list I maintain here: https://github.com/ogri-la/wowman#other-addon-managers

My own addon manager has CLI capabilities but layday/instawow is much more sophisticated in that department and (I believe) uses an API rather than scraping HTML to update addons so wouldn't have been affected by this issue. I haven't gone through their code thoroughly yet.

dark0dave commented 5 years ago

@torkus thank you for pointing that out, I had no idea. @grrttedwards, we can merge our forks into one, lets not maintain two separate version for the community.

grrttedwards commented 5 years ago

@torkus @dark0dave Thanks for chiming in.

The other addon are a great list to keep around for people in the business of looking. Thanks for the plug!

For me, this one is simple enough and works for my needs.

@dark0dave , I see you went to gitlab, but I think collaborating would be good for us. I did take my own liberty of doing a large style cleanup and refactor last night in my fork. Let’s talk about going forward together.

SveSop commented 5 years ago

Collaborating for a joint maintained source sounds like the way to go :)

kuhnertdm / wow-addon-updater

Not updating anymore #47