kuhumcst / korp-setups

Docker setups for all Korp installations maintained by NorS.
MIT License
1 stars 0 forks source link

Memo individual novels #6

Closed phildiderichsen closed 3 years ago

phildiderichsen commented 3 years ago

Towards Docker/Korp setup according to CLI argument/envvar.

We're working towards supporting different custom setups of Korp.

These changes make it possible to build one of several custom setups according to a single CLI argument.

Each custom setup has its own custom version of the frontend/app/ directory. Each of these folders is partly redundant, leading to a lot of added code. However, they are the correct unit for a single self-contained frontend config of Korp: Each represents a separate setup of Korp where changes must be made simultaneously to several files, some of which would break the other setups.

Another partly redundant addition comes from the CWB encoding scripts in backend/corpora/encodingscripts/. Some of these are autogenerated. They could be refactored to a single shell script. For now, they are not because in each case, a long list of arguments would be required, which would probably have to be stored in a file anyway.

The script encode.sh is where the corpora to be encoded are selected. Based on the single CLI argument to docker-compose.

The script create_MEMOconfigs.py is run from the MEMO encoding scripts. This saves the manual work of creating Korp configs for the MEMO corpora.

There are changes to both backend and frontend Dockerfiles and start scripts, and to the docker-compose file. The changes support the CLI argument functionality.

An important change consists of setting the CWB registry to a folder on the image rather than the host.

Obsolete files removed:

simongray commented 3 years ago

... men lad være med at merge før du har squashed!

Lav evt. et midlertidigt separat branch du kan øve det på, så du ikke ved et uheld kommer til at miste kode.

simongray commented 3 years ago

Du mergede uden at squashe...