search

kuhumcst / korp-setups

Docker setups for all Korp installations maintained by NorS.
MIT License
1 stars 0 forks source link

Normalise the ways KORP setups are structured in #8

Closed simongray closed 3 years ago

simongray commented 3 years ago

Philip has introduced a way to structure multiple Docker setups for KORP and it would make sense that my setup (the CST one) also exists as a parallel setup to his rather than several levels up in the file tree.

simongray commented 3 years ago

As discussed in our meeting today, it would make sense to leave the top-level korp/frontend/ and korp/backend/ directories in place so that they can be used to construct parent images for all setups, perhaps renaming the directories to korp/frontend-common/ and korp/backend-common/. The lines of the Dockerfiles that are specific to the CLARIN KORP setup can be cut off and placed in a separate setup in e.g. korp/setups/clarindk.

One thing to keep in mind is that using the same parent images for all setups pretty much requires any changes made to them to be tested in multiple setups before committing to master.

simongray commented 3 years ago

As of f8b262f2188d23260b88ef962112e109377a4c4f the CLARIN Korp setup in korp/setups/clarin is now constructed from base images. Or rather, the backend is used as-is, while the CLARIN frontend derives from the base frontend image.

It is now no longer possible to use the frontend base as it has no entry-point. You must provide it with one, e.g. start your custom Dockerfile with FROM korp_frontend_base.