search

kuitos / axios-extensions

🍱 axios extensions lib, including throttle, cache, retry features etc...
MIT License
831 stars 49 forks source link

Feature/use object for adapter options #21

Closed probil closed 6 years ago

probil commented 6 years ago

Fixes #18

Please verify PR and be careful about typings because I don't know TypeScript well. Maybe it's better to user inteface for adapter options?

probil commented 6 years ago

Probably you should bumb major version (3.X) after merge as this PR contain breaking changes

codecov-io commented 6 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          50     52    +2     
=====================================
+ Hits           50     52    +2
Impacted Files Coverage Δ
src/throttleAdapterEnhancer.js 100% <100%> (ø) :arrow_up:
src/cacheAdapterEnhancer.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d950a13...c61621f. Read the comment docs.

kuitos commented 6 years ago

type alias is appropriate in this scenario. I will review your pr and merge it later. After that I plan to refactor this lib with typescript these days then release v3.0.0. Thanks for your pr again! 😀

probil commented 6 years ago

You are welcome, @kuitos I'm glad to contribute :smile: