kujaku11 / mt_metadata

Tools for standardizing metadata, geared towards magnetotelluric (MT) data but is general enough to accommodate "any" type of metadata.
https://mt-metadata.readthedocs.io/en/latest/
MIT License
19 stars 5 forks source link

Add handling for attachement None #157

Closed kkappler closed 1 year ago

kkappler commented 1 year ago

Two errors encountered in issue #156

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% :warning:

Comparison is base (ae462a0) 81.74% compared to head (a7d8af4) 81.74%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fcs #157 +/- ## ========================================== - Coverage 81.74% 81.74% -0.01% ========================================== Files 264 264 Lines 18331 18333 +2 ========================================== + Hits 14985 14986 +1 - Misses 3346 3347 +1 ``` | [Files Changed](https://app.codecov.io/gh/kujaku11/mt_metadata/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JP) | Coverage Δ | | |---|---|---| | [...ansfer\_functions/io/emtfxml/metadata/attachment.py](https://app.codecov.io/gh/kujaku11/mt_metadata/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JP#diff-bXRfbWV0YWRhdGEvdHJhbnNmZXJfZnVuY3Rpb25zL2lvL2VtdGZ4bWwvbWV0YWRhdGEvYXR0YWNobWVudC5weQ==) | `93.75% <50.00%> (-6.25%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kujaku11 commented 1 year ago

This issue has been fixed with commit https://github.com/kujaku11/mt_metadata/commit/cd25167b09529d741a60bf545c8ba192a16a77f0. Therefore the pull request has been closed.