search

kujaku11 / mt_metadata

Tools for standardizing metadata, geared towards magnetotelluric (MT) data but is general enough to accommodate "any" type of metadata.
https://mt-metadata.readthedocs.io/en/latest/
MIT License
18 stars 4 forks source link

Failure to install lxml breaks build on gh actions #184

Closed kkappler closed 8 months ago

kkappler commented 8 months ago

See aurora issue # 313

It looks like something has updated with lxml and python 3.8 & 3.9 are not able to build our environment.

Here is a gh actions test that failed Dec 29 But the same test passed around a week ago.

kkappler commented 8 months ago

@kujaku11 can you please add https://github.com/laura-iris to mt_metadata with push permission in order to test branch fix_issue_184?

laura-iris commented 8 months ago

lxml is being installed through obspy and isn't pinned to a specific version there. Today lxml released version 5.0.0, which explains the change in behavior today. I haven't had time to look much further than that, but I'll get back to it next week.

laura-iris commented 8 months ago

@kkappler I don't have the permissions to restart the 3.8 pipeline in mt_metadata, but I do see that you have one in aurora that passed about an hour ago. It looks like it handled lxml v5.0.0 just fine in that case: https://github.com/simpeg/aurora/actions/runs/7402625504/job/20140872929

Makes me wonder if it was an issue with the new release that has since been dealt with?

kujaku11 commented 8 months ago

@laura-iris I just added you as a collaborator.

kujaku11 commented 8 months ago

@kkappler @laura-iris Looks like the issue was fixed, all tests pass now. Gonna close this issue for now.