kujaku11 / mt_metadata

Tools for standardizing metadata, geared towards magnetotelluric (MT) data but is general enough to accommodate "any" type of metadata.
https://mt-metadata.readthedocs.io/en/latest/
MIT License
18 stars 4 forks source link

Update broke test_issue_139 in aurora #190

Closed kkappler closed 7 months ago

kkappler commented 7 months ago

test_issue_139 was passing, but after pull latest mt_metadata get:

====================================================================== FAIL: test_tf_read_and_write (main.TestZFileReadWrite) Checks that an ingested z-file is written back out the same ----------------------------------------------------------------------Traceback (most recent call last): File "/home/kkappler/software/irismt/aurora/tests/io/test_issue_139.py", line 79, in test_tf_read_and_write assert filecmp.cmp(self.zrr_file_base, out_file_path) AssertionError---------------------------------------------------------------------- Ran 2 tests in 4.785s

I'm looking into it -- this is a placeholder and a reminder

kkappler commented 7 months ago

It looks like the conjugate of the off-diagonal terms of Inverse Coherent Signal Power Matrix is now being output from a test that reads the z_file and then rewrites it

image

Probably that test should be moved into mt_metadata

kkappler commented 7 months ago

@kujaku11 I added a test to test_zmm that the zmm in TF_ZMM can be written to file (which is not passing) -- fails with error:

Traceback (most recent call last): File "/home/kkappler/software/pycharm-community-2023.1/plugins/python-ce/helpers/pydev/_pydevd_bundle/pydevd_exec2.py", line 3, in Exec exec(exp, global_vars, local_vars) File "", line 1, in File "/home/kkappler/software/irismt/mt_metadata/mt_metadata/transfer_functions/io/zfiles/zmm.py", line 588, in write c_in_name = self.channel_nomenclature[c_in] KeyError: 'hx'

Test is on branch fix_issue_190

Can you PTAL, and once the writer is behaving we should be able to see if there really is an issue with conjugate values.

kujaku11 commented 7 months ago

Fixed on PR #192