Open kkappler opened 10 months ago
TODO: Consider adding this logic to calibration as per this pseudocode:
if decimation filters are in the removal list:
remove all non decimation filters
sort the decimation filters from lowest decimation_input_sample_rate to highest
for dec_filter in sorted_decimation_filters:
data = upsample_to_previous_sps()
data = invert_aaf(data)
Currently, decimation filters are removed by default when time series instrument response is removed.
However, this is only appropriate if the data are upsampled at each decimation stage.
Note that the decimation filters for PKD, as stored by NCEDC, have for example:
We cannot back these FIR out on 40sps data, they can only be backed out on data sampled at
decimation_input_sample_rate
.I am changing the value of include_decimation from True to False.
In future, if we want to back these filters out, we would need to upsample, and then apply them.
Here is PKD Eletric field ex with instrument response removed with
include_decimation=True
And with
include_decimation=False