kujaku11 / mth5

Exchangeable and archivable format for magnetotelluric time series to better serve the community through FAIR principles.
https://mth5.readthedocs.io/en/latest/index.html
MIT License
16 stars 4 forks source link

Run ipynb on tests #200

Closed kujaku11 closed 5 months ago

kujaku11 commented 6 months ago

Run a notebook that includes multiple steps and packages.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 18.36735% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 60.62%. Comparing base (9dd8d2b) to head (47d46a3).

:exclamation: Current head 47d46a3 differs from pull request most recent head 8ae4d55. Consider uploading reports for the commit 8ae4d55 to get more accurate results

Files Patch % Lines
mth5/clients/phoenix.py 22.58% 24 Missing :warning:
mth5/io/phoenix/phoenix_collection.py 0.00% 6 Missing :warning:
mth5/tables/channel_table.py 0.00% 6 Missing :warning:
mth5/utils/helpers.py 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #200 +/- ## ========================================== - Coverage 60.72% 60.62% -0.11% ========================================== Files 141 141 Lines 15597 15634 +37 ========================================== + Hits 9472 9478 +6 - Misses 6125 6156 +31 ``` | [Flag](https://app.codecov.io/gh/kujaku11/mth5/pull/200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JP) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/kujaku11/mth5/pull/200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JP) | `60.62% <18.36%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JP#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kkappler commented 5 months ago

@kujaku11 This PR has been tested to fix issue #199 and is ready for merge.

I tried to follow the instructions here:

But I cannot access the Settings in mth5 gh page.

A last resort would be setting fail_ci_if_error to false instead of true in tests.yml.