Tle2czml is generating positions beyond the stop of the indicated period

[Daniel-Brosnan-Blazquez]

Dears,

We have observed that tle2czml is generating positions beyond the stop of the indicated period. This is clearly done by the following functions:

• create_position
• get_future_sat_positions

Shouldn't these functions calculate a number of steps by which the last step is corresponding to the stop of the period and set the last step to be the position at the stop?

Thanks in advance for any feedback. Regards.

[Daniel-Brosnan-Blazquez]

We have already done these modifications to the code to make the library generate the last step associated to the stop:

235c235
+     number_of_positions += 1
---
-     number_of_positions += 5
237c237
+         tle, number_of_positions, start_time, end_time)
---
-         tle, number_of_positions, start_time)
246c246
+ def get_future_sat_positions(sat_tle, number_of_positions, start_time, end_time = None):
---
- def get_future_sat_positions(sat_tle, number_of_positions, start_time):
261,271d260
+ 
+     diff = (end_time - start_time).total_seconds()
+     current_time = end_time
+     eci_position, _ = sat_tle.propagate(current_time.year, current_time.month, current_time.day,
+                                         current_time.hour, current_time.minute,
+                                         current_time.second)
+ 
+     output.append(diff)
+     output.append(eci_position[0] * 1000)  # converts km's to m's
+     output.append(eci_position[1] * 1000)
+     output.append(eci_position[2] * 1000)

So, we share them in case it helps to understand the question. Here you have the link to the tle2czml.py file in our forked repository: https://github.com/Daniel-Brosnan-Blazquez/tle2czml/blob/master/tle2czml/tle2czml.py

Thanks in advance for any feedback. Regards.