core & utils were generated using @nrwl/node:library, should be @nrwl/js:library instead

kukeiko / entity-space

MIT License

5 stars 1 forks source link

core & utils were generated using @nrwl/node:library, should be @nrwl/js:library instead #133

Closed kukeiko closed 2 months ago

kukeiko commented 2 years ago

core & utils packages should be consumable by both browser & node.js, and the tsconfig.lib.json of those libraries require "node" as a type, so that's wrong.

before just removing "node" from the types property; check if any other things would change (as if we were to generate them from scratch using @nrwl/js:library instead of @nrwl/node:library)

kukeiko commented 2 years ago

working on #152, and I found these differences in the criteria package:

project.json build executor is different: @nrwl/js:tsc vs @nrwl/node:package
package.json has "type": "commonjs"
no .babelrc file
jest.config.js has no testEnvironment (core has testEnvironment: "node")
tsconfig files are quite different - core has types "node", criteria has more strict flags by default, but both use commonjs as the module specifier - one in the tsconfig.json, one in the tsconfig.spec & tsconfig.lib

kukeiko commented 2 years ago

found another change while generating an @nrwl/js:tsc @entity-space/common (and setting the publishable flag to true): tools/scripts/publish.mjs got added. did i miss "publishable" flags in the other libs (core, utils, criteria)?

kukeiko commented 2 months ago

obsolete as nx has been removed in #219