implement parsing queries

kukeiko / entity-space

MIT License

5 stars 1 forks source link

implement parsing queries #194

Closed kukeiko closed 1 year ago

kukeiko commented 1 year ago

What

Implement parsing Queries from a string (there already is a satisfactory string representation of Queries) Also, while we're at it: look at simplifying parsing of criteria, finding bugs and fixing them, finding new test cases

Why

so that we can write more concise tests (currently the primary reason to do it asap)
so that we can easily serialize/deserialize them
so that a user can have a textbox where they enter a query and see the result (for e.g. stackblitz playgrounds)

kukeiko commented 1 year ago

as far as I can tell the implementation is pretty much complete (or at least satisfactory). what is missing is some cleanup, e.g. parse-query.fn.ts contains quite a few local functions which I might want to move to separate files

kukeiko commented 1 year ago

meh, cleanup not necessary. feature is working, don't think there'll be any major crazy changes to it, so I'm closing the issue. if anything comes up I can always reopen.