kukeiko / entity-space

MIT License
5 stars 1 forks source link

rework EntitySelection to require explicit list of selected properties #200

Closed kukeiko closed 11 months ago

kukeiko commented 1 year ago

What

Currently, the EntitySelection allows as a value an object that does not explicitly list all properties that are to be selected. When it comes to performing operations (subtract/merge/intersect), it'll query the EntitySchema for the default selection when necessary.

The reason I did it this way (that change is actually quite recently and wasn't like this for a long time before that) was to make construction of EntitySelections easier for the user.

Why

Several reasons:

kukeiko commented 11 months ago

merging, subtraction & intersection logic now relies on selected being explicitly listed, so we can close this