Description below might be wrong - I just realized we have an "AllCriterion" to represent the complete set. Currently trying to figure out why we need it, and if we do - keep it and reject this issue.
=> did a quick check, looks like I introduced it to always have a Criterion instance in the EntityQuery (as opposed to it being undefined). Probably to reduce required "is undefined?" checks. Doesn't sound too bad, so I'll keep it. There are other things to worry about now.
What
ICriterion.merge() can currently only return false | ICriterion, but it should be able to return true as well.
Why
Because !{1,2,3} merged with !{4,5,6} should be true (to represent the complete set)
Whoopsie
Description below might be wrong - I just realized we have an "AllCriterion" to represent the complete set. Currently trying to figure out why we need it, and if we do - keep it and reject this issue.
=> did a quick check, looks like I introduced it to always have a Criterion instance in the EntityQuery (as opposed to it being undefined). Probably to reduce required "is undefined?" checks. Doesn't sound too bad, so I'll keep it. There are other things to worry about now.
What
ICriterion.merge() can currently only return false | ICriterion, but it should be able to return true as well.
Why
Because !{1,2,3} merged with !{4,5,6} should be true (to represent the complete set)