kukugt / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

License informations wrong or missing #158

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Per Hansen prepares a package for debian at the moment. The copyright
informations should be correct for that. Licensecheck revealed that the
header is complete missing in all files from glN64. The files from r4300,
glide64 have a modified header which confuses licensecheck and
opengl/OGLFT.* have a wrong FSF address.

There are more problem as you can see in licensecheck output

Many files of the gui have really misterious sentences like "either version
2 of the Licence" the or part is missing (or the either part is too much).
I will not change anything in ./main/ because of that.

Original issue reported on code.google.com by sven@narfation.org on 9 Oct 2008 at 9:21

Attachments:

GoogleCodeExporter commented 8 years ago
Not sure if you're aware, but we know of these issues. Actually this misses 
some of 
the improperly licensed icons in glide64. We made a new license template (with 
the 
correct FSF and version info.) but have not had time to apply to all the source 
files. 

As far as the bigger problems, I'm one of, and have personally spoken to the 
other 
GUI authors. All of us agree on GPL version 2.0 or later, so that can be fixed. 
Just a question of not having done so yet. 

glN64's license issues can't be easily resolved, as the original author can't 
be 
contacted. A license strict Debian package will likely need to have this plugin 
removed. There is a GPLed fork of the original code but it only runs on win32 
and 
reporting will take some time.

Original comment by sknau...@wesleyan.edu on 11 Oct 2008 at 2:46

GoogleCodeExporter commented 8 years ago
Equivalent fixes for the following patches

dummy_video
dummy_input
memory_license_fix

applied as of r1102

Original comment by sknau...@wesleyan.edu on 11 Oct 2008 at 4:06

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Equivalent fixes for the following patches 

r4300 
debugger
add_lgpl

applied as of r1106.

Additionally, the regression test, main, and Qt4 GUI had license header commits.

Note version 2.1 of the LGPL was added as 2.1 or later is what all our source 
is 
licensed under.

The changes proposed to the OGLFT library were rejected as the changes were 
only 
formatting (i.e. the same words were on different lines) and that header is 
provided by upstream. We prefer to use the header provided by upstream if 
possible. 
The same errors appears in say main/md5.c md5.h adler32.c, etc. All our source 
(barring glN64) is actually OSI and DFSG approved. Sadly licensecheck relies on 
very strict license strings and some older packages prefer their own statements.

The Glide64 stuff is also changing formatting without changing words. Since 
there 
is an active upstream for this plugin, I want to confirm before applying our 
header. Its very possible this will just be rejected. 

The Blight changes will occur in the next week as rewriting a large part of the 
plugin is actually my current project. :)

Thanks for the patches, btw.

Original comment by sknau...@wesleyan.edu on 12 Oct 2008 at 12:12

GoogleCodeExporter commented 8 years ago
The blight license updates were actually made independent from my rewriting 
work. 
The gtk debugger changes were made in r1134.

According to my Sid version of licensecheck the only files which give issue are 
correctly licensed files which doesn't use the exact strings licensecheck looks 
for. This consists of some files licensed under 3DFX's open source license 
(which 
is DFSG okay) in glide64, the zlib code from Mark Adler in the core and rice, 
some 
of the GPLed 7zip code.

The only issues for Debian inclusion from my knowledge are:
- glN64 is unlicensed (while the source is publically available from the 
original 
author we can't get in contact with him), a Debian release will likely have to 
not 
include this plugin. 
- Windows icons in glide64. (on the todo to be replaced)
- Getting in touch with marshall (our demo rom author) for a copy of his source 
and 
to confirm that it is GPLed.

Marking issue as closed as all the source issues present have been either fixed 
or 
rejected. (The glide64 and OGLFT headers have been left intact - the code is 
very 
clearly GPLed)

Original comment by sknau...@wesleyan.edu on 29 Oct 2008 at 9:51