Screenshot naming convention

[GoogleCodeExporter]

Screenshots should be better named, for example SUPERMARIO6401.png vs
Screenshot01.png

Original issue reported on code.google.com by sgorman07@gmail.com on 14 Apr 2008 at 10:22

[GoogleCodeExporter]

Anyone have any idea on how we could achieve this? After looking at the source, 
it
looks like the plugins handle the naming. Possibly we could have it write the
screenshots to g_SshotDir/ROM_HEADER->nom (assuming that nom is the internal 
header).

So example:

/.mupen64plus/screenshots/SUPER MARIO 64/mupen64plus_001.png

Original comment by sgorman07@gmail.com on 17 Apr 2008 at 6:11

[GoogleCodeExporter]

in the API call, the caller is just supposed to supply the screenshot 
directory. We
can modify this so the full path to the filename is passed in. Then mupen64plus 
can
use any convention it wants for naming screenshot files.

Original comment by ebenbl...@gmail.com on 17 Apr 2008 at 7:22

[GoogleCodeExporter]

Please do not create new sub-directories to put the screenshots by game name. 
Modifying the API to pass the whole file path instead of just the dir path makes
sense.  This feature will need to be implemented in the Rice and glN64 plugins 
as
well as the core; I believe that glide64 doesn't write screenshots.  It would 
be nice
if it did. :) I added screenshot capability to RiceVideo, I suppose I could do 
it for
glide64 as well.

Original comment by richard...@gmail.com on 17 Apr 2008 at 11:56

[GoogleCodeExporter]

Created issue 60 to implement screenshot api call in glide64.

Original comment by ebenbl...@gmail.com on 18 Apr 2008 at 6:22

[GoogleCodeExporter]

what if we passed the captureScreen to a pointer that held the data about the 
frame,
then wrote the png to a file from there (inside the core)

Original comment by sgorman07@gmail.com on 19 Apr 2008 at 8:23

[GoogleCodeExporter]

@sgorman07:  I think something like you suggested would be better than the 
current
implementation from a design perspective, because the PNG writing code would 
only
need to be in one place (the core) instead of 3.  But it would also require 
extending
the API in a non-backwards-compatible way.  Since the core doesn't know the 
screen
resolution, the plugin should malloc() the buffer and fill it with RGB data and 
pass
back the buffer pointer plus the width and height.  This would also allow the
savestate screenshot to be implemented much more cleanly.

Original comment by richard...@gmail.com on 19 Apr 2008 at 12:40

[GoogleCodeExporter]

Fixed as of r283.

Log:
added a lowercase function. changes a string to lowercase.
stub: void lowercase(char string[]);

modified the screenshot function to use the roms header (without spaces, and
converted to lowercase) name:

example: supermario64_001.png

Original comment by sgorman07@gmail.com on 23 Apr 2008 at 6:08

• Changed state: Fixed