kukugt / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

Use icons from icon theme #93

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Currently mupen64plus ships a set of icons from KDE4. While nice, it would
be even better if those would only be used as a fallback, with a priority
to use icons from the system's theme. As both GNOME and KDE4 (as well as
other desktops) use the same icon name spec (from freedesktop) this should
be in the best interest for everyone. I did a quick list with the icon
names to use:

Toolbar:

Open        document-open

---
Start       media-playback-start
Stop        media-playback-pause
Pause       media-playback-stop

---
Fullscreen  view-fullscreen

---
Options     preferences-desktop

Pref dialog:

Video       video-display
Audio       audio-card
Input       input-gaming

As a fallback solution, you could just rename the icons you ship ATM to the
proper spec names and inside a hicolor theme structure inside icons/

Then, add this directory to the search path for icon themes (normally
$PATH/share/icons)

Original issue reported on code.google.com by michael....@gmail.com on 19 May 2008 at 12:47

GoogleCodeExporter commented 8 years ago
Partially fixed in rcs branch. Do Gtk icons need to be called a specific way to 
be 
replaced by the Gtk-qt theme engine? 

Original comment by sknau...@wesleyan.edu on 25 May 2008 at 6:06

GoogleCodeExporter commented 8 years ago
Isn't the "Gtk-qt theme engine" only for widget styling? IIRC selecting another 
icon
theme in KDE does also affect Gtk apps... provided we are talking about KDE4, 
as KDE3
does not use the freedesktop spec names yet. 

Original comment by michael....@gmail.com on 25 May 2008 at 6:32

GoogleCodeExporter commented 8 years ago
Yep, I'm primarily a KDE3 user. :) I figured out how to fix this correctly. The 
Gtk 
icon theme method is much higher quality than just using the built-in gtk stock 
icons (which is why the gtk-qt theme engine replaces them differently), the 
difference I found that was at the crux of the previous comment. It should be 
possible to get a KDE3 iconset on the gtk-qt theme engine with a suitable Gnome 
icon theme. There's a crystalsvg (the default KDE3 set) for Gnome that I found. 

However, getting it selected seems somewhat difficult. 

Anyway... here's a peak of the rcs branch which has some icon improvements.
http://www.emutalk.net/showthread.php?t=44506 
Once I get everything looking nice on my machine and in rcs, I'll merge that 
part 
to trunk.

I agree with most of your icon choices and think I'll add a medium 24x24 icon 
size 
as those are the size of normal toolbars and we just have 16x16 and 32x32. 

Original comment by sknau...@wesleyan.edu on 28 May 2008 at 7:36

GoogleCodeExporter commented 8 years ago
Fixed in rcs commit r491. Added medium size as 22x22. 

Used preferences-system instead of preferences-desktop.

Also, to get this working in KDE3 you need a minimum Gnome icon set to 
overright 
the 9 icons listed in default and to install the gnome-settings-daemon. If 
there is 
interest, I'll post the theme to be downloaded.

Original comment by sknau...@wesleyan.edu on 29 May 2008 at 1:57