kukuminer / ta-app

Online application and selection platform for teaching assistants
0 stars 0 forks source link

Add campus information to sessions #130

Open jonatanschroeder opened 1 month ago

jonatanschroeder commented 1 month ago

With Markham starting soon, we need to identify what applicant preferences are for which campus they are willing to work at. This could be done by adding a table on campus, and then assign a section to a campus. The application table should also include the campus. For applicants, then, the courses should be broken down by campus (i.e., list all courses with sections at Keele, then list all courses with sections at Markham).

kukuminer commented 1 month ago
kukuminer commented 1 month ago

@jonatanschroeder should I make a new db migration for each change, or can I make all the changes in one file? ie. Can I put the following all in one new migration, or should I make a separate file for each? CREATE ENUM... ALTER TABLE section ADD campus... ALTER TABLE applicant ADD campus...

The migrations are skipped if they're already present, but I'm not sure if it's better to have it split anyway or all in one is ok for performance/simplicity

jonatanschroeder commented 1 month ago

All in one is fine.

kukuminer commented 1 month ago

Thanks. New question about adding columns: if I set a column as required (ie. NOT NULL), it must have a default value. Is it safe to put Keele as the default for the application table? Should I put Keele as the default for the section table too?

jonatanschroeder commented 1 month ago

Keele is fine. I can update them manually on deploy.