search

kul-optec / drn

Newton-type Douglas-Rachford splitting method and ADMM for structured nonconvex optimization
7 stars 7 forks source link

Fix L-BFGS mex function #2

Open lostella opened 6 years ago

lostella commented 6 years ago

As pointed out by @Zilleplus here the L-BFGS mex function should be fixed as in here in order to avoid compatibility problems: we should be using mwSize in place of size_t for specifying array dimensions.

MelisWillem commented 6 years ago

We should just copy over lbfgs.c from ForBeS, because some of the parameters that where put to size_t should still be int to be safe. I checked all this and fixed it in ForBeS...

lostella commented 6 years ago

Yep, I just opened this to pin down the issue

MelisWillem commented 6 years ago

already made pull request #3 also changed setup, still needs to be tested on Matlab tough