codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.
Project coverage is 4.02%. Comparing base (
1b9be38) to head (618fa50).
| Files | Patch % | Lines |
|---|---|---|
| pages/api/v0.2/messages.ts | 0.00% | 74 Missing :warning: |
| pages/api/v0.1/messages.ts | 0.00% | 7 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1105 +/- ## ======================================== - Coverage 4.11% 4.02% -0.09% ======================================== Files 157 158 +1 Lines 3623 3702 +79 Branches 350 367 +17 ======================================== Hits 149 149 - Misses 3470 3549 +79 Partials 4 4 ``` | [Flag](https://app.codecov.io/gh/kula-app/OnLaunch/pull/1105/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kula-app) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kula-app/OnLaunch/pull/1105/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kula-app) | `4.02% <0.00%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kula-app#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request introduces the messages endpoint v0.2 which will replace the current v0.1 used by client libraries.
The main necessity of this pull request is caused due to a DTO decoding issue in https://github.com/kula-app/OnLaunch-iOS-Client, where I forgot to implement backwards compatibility when parsing the
ActionType.The issue in the client will be fixed with https://github.com/kula-app/OnLaunch-iOS-Client/pull/53 but due to apps shipped with the latest release of the iOS client, we are bumping the API endpoint version too, and filter out any newly introduced action types.
This will also require updates to the Android and Flutter clients, but as new action types require changes in the clients anyways, there won't be an issue until then.