search

kulakowka / react-bulma

React.js components for Modern CSS framework based on Flexbox
https://code-typing-tutor.com
MIT License
471 stars 58 forks source link

Support TypeScript? #32

Open koddr opened 6 years ago

koddr commented 6 years ago

Hello.

What about supporting TypeScript? When I try to use, I see this:

 Try `npm install @types/reactbulma` if it exists or add a new declaration (.d.ts) file containing `declare module 'reactbulma';`

And, of cause, npm install @types/reactbulma do nothing. Would be great to start supporting TS at middle of 2018 for your awesome package..

kulakowka commented 6 years ago

I don't have an experience with TypeScript. But i will be glad if you send a PR.

thib92 commented 5 years ago

Hi ! I'm currently working on implementing typings for this project. I will submit a PR when it is ready 😄 Since the repo isn't created in TS, the whole props typings must be done by hand.

thib92 commented 5 years ago

PR open #34 😄

loopmode commented 4 years ago

Too bad there is no progress whatsoever here, since there already is a pretty decent PR. I just started typing this out manually for a pet project, but I'll stop that. I will either contribute the proposed typings to @types/reactbulma or fork this repo and publish it under my own npm scope.

thib92 commented 4 years ago

@loopmode since the PR isn’t merged into the repo, feel free to take the typings I made and propose them on DefinitelyTyped. I don’t use this project anymore.

This is probably the best thing to do since everyone using this package with TS will get the typings! Publishing it under your own NPM package means you’ll have to maintain a fork with all the updates!

loopmode commented 4 years ago

@thib92 what updates? Just kidding :D of course you're right, @types/reactbulma would be much preferable. I just have to get familiar with the DefinitelyTyped repo and workflow. They do have good documentation and recommendations, already looked into. I just know from GitHub what a massive repo it is and have some respect, but it shouldn't be a problem.