kulakowka / react-bulma

React.js components for Modern CSS framework based on Flexbox
https://code-typing-tutor.com
MIT License
471 stars 52 forks source link

Typescript definition file for prop types #34

Closed thib92 closed 3 years ago

thib92 commented 6 years ago

Fixes #32. In this PR I created a Typescript definition file, changed the scripts to take it into account, and fixed a few ESLint problems.

Would love to have feedback on this. I used the PropTypes to infer the TS types. If the PropTypes are not up to date or are wrong, the TS types will be wrong too.

By the way, I think it would be awesome to convert the project to Typescript, so that the definition file is generated automatically, and so that the PropTypes are actually properly checked at compile time, assuring a better quality code. Would love to hear your opinion on this @kulakowka.

adesnmi commented 5 years ago

Any updates on this @kulakowka?