kulakowka / react-bulma

React.js components for Modern CSS framework based on Flexbox
https://code-typing-tutor.com
MIT License
471 stars 58 forks source link

Consider to use classnames package for create a class #5

Closed kresli closed 6 years ago

kresli commented 6 years ago

currently you are creating classes with if statements. I think it would be much easier to use https://www.npmjs.com/package/classnames module. I'm happy to help with it.

kulakowka commented 6 years ago

@Julian-B90 what do you think about it? I thought it over. I think we should avoid using unnecessary dependencies.

Julian-B90 commented 6 years ago

@kulakowka i think classnames was a good module for react-bulma. We use it in our company projects.

Julian-B90 commented 6 years ago

@kresli maybe you can made a fork and help us with the rebuild with classnames? I have start with Button https://github.com/kulakowka/react-bulma/blob/master/src/components/Button/Button.js

kulakowka commented 6 years ago

@Julian-B90 I will do all the other components.

kulakowka commented 6 years ago

completed