kulapio / libra-wallet-poc

💰POC Libra wallet
https://dev.kulap.io/libra
MIT License
142 stars 44 forks source link

change buefy.css path and update vue.config.js attr #1

Closed korrio closed 5 years ago

korrio commented 5 years ago

Since I can't npm install in by default step. So I have to manually npm install inside ./node_modules/vuefy and run npm run build on that directory.

And I see the buefy.css is located in ./node_modules/vuefy/dist directory. Then I change path of buefy.css

And for vue.config.js The baseUrl attr will deprecate soon.

totiz commented 5 years ago

I've build failed, could you please try rebuild and make sure everything work fine.

rm -rf node_modules
npm install
npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/web3-providers-ws/websocket@git:/github.com/frozeman/WebSocket-Node.git#6c72925e3f8aaaea8dc8450f97627e85263999f2" as it does not contain a package.json file.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/totiz/.npm/_logs/2019-06-23T10_10_20_592Z-debug.log
korrio commented 5 years ago

After rm -rf node_modules Then I try yarn install instead of npm install and it works fine.

totiz commented 5 years ago

@korrio Oh I see, could you please make sure that It works with npm as on master branch npm install is work just fine. some developers don't have yarn so I prefer to use npm as default.

korrio commented 5 years ago

Please merge only https://github.com/kulapio/libra-wallet-poc/pull/1/commits/f4a4307061750b47962559fb3c7ae0eeb52a3dec